Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #905 #906

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fix for #905 #906

merged 3 commits into from
Nov 16, 2023

Conversation

calad0i
Copy link
Contributor

@calad0i calad0i commented Oct 31, 2023

Fix for #905

  • Bug fix (non-breaking change that fixes an issue)

Tests

test/pytest/test_stream_multi_clone.py

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@calad0i calad0i changed the title fix multi clones w/ diff outs in stream io Fix for #905 Oct 31, 2023
@vloncar vloncar added the please test Trigger testing by creating local PR branch label Oct 31, 2023
@vloncar
Copy link
Contributor

vloncar commented Oct 31, 2023

Looks reasonable. If it doesn't break existing tests, I propose we merge this

@jmduarte jmduarte added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Nov 16, 2023
@jmduarte jmduarte modified the milestones: v0.8.1, v0.8.0 Nov 16, 2023
@jmduarte jmduarte merged commit 67c39b3 into fastmachinelearning:main Nov 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple stream clones with different numbers of outputs crash Keras converter.
3 participants