Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness at different parts of the codemeta.json creation #175

Closed
maelle opened this issue Jul 2, 2018 · 5 comments
Closed

Robustness at different parts of the codemeta.json creation #175

maelle opened this issue Jul 2, 2018 · 5 comments
Milestone

Comments

@maelle
Copy link
Member

maelle commented Jul 2, 2018

codemetar gets data from GitHub API, soon from a csv with information about rOpenSci reviews cf #23 .

It'd make sense to check for the presence of an internet connection, to try a few times, and to output NULLs instead of errors.

@maelle
Copy link
Member Author

maelle commented Sep 3, 2018

Also be more robust to hitting GitHub API rate limits, especially in the absence of a token.

@maelle
Copy link
Member Author

maelle commented Nov 22, 2018

  • if rOpenSci review badge, rOpenSci review info gotten from a JSON on the web.
  • if GitHub repo, Preferred README, and repo topics, gotten via GitHub API (gh::gh()) . In a try().

@maelle
Copy link
Member Author

maelle commented Nov 20, 2019

@sckott have you actually observed many failures when building the registry?

@sckott
Copy link

sckott commented Nov 20, 2019

not many no. There was that PR #247 and #236 , but those fixed now.

The biggest thing I can think of is the keywords problem, which I don't really have any ideas how to fix since its so intermittent

@maelle maelle modified the milestones: 0.2.0 release, 0.1.9 Nov 21, 2019
maelle added a commit that referenced this issue Nov 21, 2019
@maelle
Copy link
Member Author

maelle commented Nov 21, 2019

fixed iv dev by #255

@maelle maelle closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants