Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not define :init-ending if robot-model's :define-min-max-table exists. #510

Closed

Conversation

snozawa
Copy link
Collaborator

@snozawa snozawa commented Apr 18, 2017

Do not define :init-ending if robot-model's :define-min-max-table exists (euslisp/jskeus#428).
This will fix the bug (#508) because unnecessary :init-ending conflict is resolved.

Please check @YoheiKakiuchi.
If OK,please merge after euslisp/jskeus#428.

…ot define :init-ending if robot-model's :define-min-max-table exists (euslisp/jskeus#428). This will fix the bug (start-jsk#508) because unnecessary :init-ending conflict is resolved.
@YoheiKakiuchi YoheiKakiuchi self-requested a review April 18, 2017 11:01
Copy link
Member

@YoheiKakiuchi YoheiKakiuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed for backward compatibility?
If so, it is better to add comment describe so.

And, it is better to add comment that :define-min-max-table is overridden, defined in irtrobot.l

@snozawa
Copy link
Collaborator Author

snozawa commented Apr 18, 2017

Close according to #509.

@snozawa snozawa closed this Apr 18, 2017
@snozawa snozawa deleted the fix_initending_using_jskeus branch April 18, 2017 14:13
itohdak pushed a commit to itohdak/rtmros_tutorials that referenced this pull request Jan 10, 2019
[jsk_hrp2_ros_bridge/sensors_monitor.py] Add unit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants